Collection of various notes about development practices, how-to's or checklists.
Adding a new ioctl, extending an existing one
- add code to strace so the ioctl calls are parsed into a human readable form. Most of the ioctls are already implemented and can be used a reference.
The tracepoint message format should be compact and consistent, so please stick to the following format:
- key=value no spaces around =
- separated by spaces, not commas
- named values: print value and string, like "%llu(%s)", no space between, string in parens
- avoid abbreviating key values too much, (eg. use 'size' not 'sz')
- hexadecimal values are always preceded by 0x (use "0x%llx)
- use struct btrfs_inode for inode types, not plain struct inode
- inode number type is u64, use btrfs_ino if needed
- key can be printed as [%llu,%u,%llu]
- enum types need to be exported as TRACE_DEFINE_ENUM
"root=%llu(%s) offset=%llu size=%llu num_stripes=%d sub_stripes=%d type=%s"
Error messages, verbosity
- use btrfs_* helpers (btrfs_err, btrfs_info, ...), they print a filesystem identification like
BTRFS info (device sdb): ...
- first letter in the string is lowercase
- message contents
- be descriptive
- keep the text length reasonable (fits one line without wrapping)
- no typos
- print values that refer to what happend (inode number, subvolume id, path, offset, ...)
- print error value from the last call
- no "\n" at the end of the string
- no ".'' at the end of text
- un-indent the string so it fits under 80 columns
- don't split long strings, overflow 80 is ok in this case (we want to be able to search for the error messages in the sources easily)
- btrfs_err -- such messages have high visibility so use them for serious problems that need user attention
- btrfs_warn -- conditions that are not too serious but can point to potential problems, the system should be still in a good state
- btrfs_info -- use for informative messages that are useful to see what's happening in the filesystem or might help debugging problems in the future and are worth keeping in the logs
Error handling and transaction abort
Please keep all transaction abort exactly at the place where they happen and do not merge them to one. This pattern should be used everwhere and is important when debugging because we can pinpoint the line in the code from the syslog message and do not have to guess which way it got to the merged call.
- do not use spin_is_locked but lockdep_assert_held
Coding style preferences
Before applying recommendations from this sections, please make sure you're familiar with the kernel coding style guide.
- comment new data structures
- comment new enum/define values, brief description or pointers to the code that uses them
Kernel config options
Compile-time config options for kernel that can help debugging, testing. They usually take a hit on performance or resources (memory) so they should be selected wisely. The options in bold should be safe to use by default for debugging builds.
Please refer to the option documentation for further details.
- devices for testing
- CONFIG_BLK_DEV_LOOP - enable loop device
- for fstests: DM_FLAKEY, CONFIG_FAIL_MAKE_REQUEST
- CONFIG_SCSI_DEBUG - fake scsi block device
- CONFIG_SLUB_DEBUG - boot with slub_debug
- CONFIG_DEBUG_PAGEALLOC + CONFIG_DEBUG_PAGEALLOC_ENABLE_DEFAULT (on newer kernels)
- CONFIG_BTRFS_DEBUG, CONFIG_BTRFS_ASSERT, CONFIG_BTRFS_FS_RUN_SANITY_TESTS
- CONFIG_DEBUG_SPINLOCK, CONFIG_DEBUG_MUTEXES
- CONFIG_PROVE_LOCKING, CONFIG_LOCKDEP
- sanity checks
- CONFIG_DEBUG_STACK_USAGE, CONFIG_HAVE_DEBUG_STACKOVERFLOW, CONFIG_DEBUG_STACKOVERFLOW
- verbose reporting
- CONFIG_TRACING etc
xfstests has very few "hard" requirements and will succeed without running many of the tests. In order to ensure full test coverage, your test environment should provide the following.
Kernel config options for complete test coverage
Kernel config options for better bug reports
See the list in the section above for more options.
User space utilities and development library dependencies
- xfsprogs >= 4.3.1
xfs_io -c reflinkis required.
Note: This list may be incomplete.
- At least 4 identically sized partitions/disks/virtual disks, specified using
- some tests may require 6 such partitions
- some tests need at least 10G of free space, as determined by
df, ie. the size of the device may need to be larger
fsgqauser and group must exist.
123456-fsgqauser and group must exist.